Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: get_dummies: validate parameters at API layer #5792

Open
mvashishtha opened this issue Mar 15, 2023 · 0 comments
Open

REFACTOR: get_dummies: validate parameters at API layer #5792

mvashishtha opened this issue Mar 15, 2023 · 0 comments
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers Help Wanted 🌐 Issues good for external contributors. P3 Very minor bugs, or features we can hopefully add some day.

Comments

@mvashishtha
Copy link
Collaborator

mvashishtha commented Mar 15, 2023 •
edited
Loading

e.g. prefix and prefix_sep must both have the same length as the columns to encode. we can probably copy these checks from pandas: https://github.com/pandas-dev/pandas/blob/2a983bb1c2e0c962d828dcd9c828d95c5d82bb5a/pandas/core/reshape/encoding.py#L164-L175
@mvashishtha mvashishtha added good first issue 🔰 Good for newcomers Code Quality 💯 Improvements or issues to improve quality of codebase Help Wanted 🌐 Issues good for external contributors. P3 Very minor bugs, or features we can hopefully add some day. labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers Help Wanted 🌐 Issues good for external contributors. P3 Very minor bugs, or features we can hopefully add some day.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvashishtha