REFACTOR: Add mypy checks for modin.core.dataframe.algebra

[mvashishtha]

procedure:

1. Follow contributing instructions to set up your modin development environment
2. create a new git branch for your changes
3. add modin/core/dataframe/algebra to mypy.ini
4. try adding mypy types to that directory and running mypy --config-file mypy.ini modin/core/dataframe/algebra until it passes
   For example, this line:

   modin/modin/core/dataframe/algebra/binary.py

   Line 26 in 3ee4fa0

   def register(cls, func, join_type="outer", labels="replace"):

   
   should become something like
   def register(cls, func: Callable, join_type: str ="outer", labels: str ="replace"):
5. create a PR by following the contributing guide.

[mohanadtalat91]

Hello, @mvashishtha

I'm so interested in contributing for this issue, and I just want to know the problem statement or what should I do to solve this issue ??
By the way, it's my first time to contribute to "modin" repo.

Thanks in advance

[mvashishtha]

Hi @mohanadtalat91,

thank you very much for your interest. I want @sofezticated-gentleman to take this issue because I pointed it to him first in #4633.

However, it would be great if you could take issue #5079 instead. Both issues are for adding mypy types. mypy is a type checker. Integrating it into the Modin codebase will make it easier to understand the Modin code and to write bug-free code. You can read more about mypy in its documentation. For #5079, the goal is to add types to all the files in modin/core/dataframe/base, so that mypy is satisfied with the types in all files in that directory. You can make a PR to fix the issue by following the steps in the first post of this issue, except for modin/core/dataframe/base instead of modin/core/dataframe/algebra. Please let me know if you have more questions.

[yashgosa]

@mvashishtha after following the contributing guidelines, I have cloned the repository but I am stuck at adding a remote branch
git remote add upstream git@github.com:modin-project/modin.git , it says
fatal: not a git repository (or any of the parent directories): .git

[mvashishtha]

@sofezticated-gentleman you have to go into the cloned directory, e.g. if you cloned the repo into directory modin, first do:

cd modin

Then you should be able to add the remote.

[yashgosa]

ooh thanks, I think so that should be added to contributing document

[yashgosa]

@mvashishtha , I'm getting error :
ERROR: Could not find a version that satisfies the requirement ray[default]>=1.4.0 (from modin[all]) (from versions: none) ERROR: No matching distribution found for ray[default]>=1.4.0
for:
$ pip install -e ".[all]"

[yashgosa]

@mvashishtha also getting the same error for $ pip install -r requirements-dev.txt

[yashgosa]

C:\Users\Yash PC\modin>pytest modin/pandas/test/test_concat.py


ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov-config=setup.cfg --cov=modin --cov-append --cov-report=xml
  inifile: C:\Users\Yash PC\modin\setup.cfg
  rootdir: C:\Users\Yash PC\modin

[yashgosa]

@mvashishtha also is there any discord channel or some forum of this org??

[mvashishtha]

also is there any discord channel or some forum of this org??

Let's continue this conversation in the Modin slack either on a new post in #modin-development or in DMs-- my name on slack is "Mahesh Vashishtha".

For the ray error, could you please try to list the available versions of ray by following the instructions here? I'm surprised that a version of ray >= 1.4.0 is not available on your system.

[yashgosa]

hey @mvashishtha i think so ray isnt available for windows sys but we can install it with help of anaconda and Docker

[mvashishtha]

@sofezticated-gentleman my impression is that ray is available on windows. Could you share some details of your environment, including operating system version, python version, conda version, pip version?

Do you need any more help getting your development environment set up?

[pyrito]

@sofezticated-gentleman I'd encourage you to go ahead and join the Modin slack so that more folks can help you get onboarded with this. Thanks for taking on this issue!