Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy checks for modin.pandas #4633

Open
pyrito opened this issue Jul 1, 2022 · 2 comments
Open

Add mypy checks for modin.pandas #4633

pyrito opened this issue Jul 1, 2022 · 2 comments
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P2 Minor bugs or low-priority feature requests

Comments

@pyrito
Copy link
Collaborator

pyrito commented Jul 1, 2022

We need to expand our mypy checks to cover Python files in modin/pandas/. There may be a lot of files to modify at once so folks should focus on type annotations one file at a time. Please make sure to add files to mypy.ini!
@pyrito pyrito added the Code Quality 💯 Improvements or issues to improve quality of codebase label Jul 1, 2022
@pyrito pyrito added the P2 Minor bugs or low-priority feature requests label Aug 31, 2022
@mvashishtha mvashishtha added good first issue 🔰 Good for newcomers Help Wanted 🌐 Issues good for external contributors. hacktoberfest labels Sep 22, 2022
@yashgosa
Copy link

yashgosa commented Oct 3, 2022

hey @pyrito well i wanna contribute to this project but its my first issue to this org and imma newbie can you please elaborate on what exactly do I have to do???

@mvashishtha
Copy link
Collaborator

@sofezticated-gentleman thank you very much for your interest. I think #5073 would be a better first issue. I left some instructions in the issue description. Please let me know if you need help with #5073.

@mvashishtha mvashishtha mentioned this issue Oct 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase good first issue 🔰 Good for newcomers hacktoberfest Help Wanted 🌐 Issues good for external contributors. P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pyrito @mvashishtha @yashgosa