Skip to content

Commit 8fe723f

Browse files
committed
Rename some entities for improved readability
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
1 parent a1b58d3 commit 8fe723f

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

examples/cluster/experimental_cloud.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
logger = logging.getLogger()
2525
logger.setLevel(logging.DEBUG)
2626

27-
from modin.experimental.cloud import Provider, cluster, get_connection
27+
from modin.experimental.cloud import Provider, Cluster, get_connection
2828

2929

3030
aws = Provider(Provider.AWS, os.path.join(os.path.abspath(os.path.dirname(__file__)), 'aws_credentials'), 'us-west-1')
31-
with cluster(aws, cluster_name='rayscale-test') as c:
31+
with Cluster(aws, cluster_name='rayscale-test') as c:
3232
conn = get_connection()
3333
import pdb;pdb.set_trace()
3434
modin = conn.modules.modin

modin/experimental/cloud/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@
1212
# governing permissions and limitations under the License.
1313

1414
from .base import ClusterError, CannotSpawnCluster, CannotDestroyCluster
15-
from .cluster import Provider, Cluster
15+
from .cluster import Provider, BaseCluster
1616
from .connection import Connection
1717

1818

19-
def cluster(
19+
def Cluster(
2020
provider: Provider,
2121
project_name: str = None,
2222
cluster_name: str = "modin-cluster",
2323
worker_count: int = 4,
2424
head_node_type: str = None,
2525
worker_node_type: str = None,
2626
spawner: str = "rayscale",
27-
) -> Cluster:
27+
) -> BaseCluster:
2828
if spawner == "rayscale":
2929
from .rayscale import RayCluster as Spawner
3030
else:

modin/experimental/cloud/cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def default_worker_type(self):
8686
return self.__DEFAULT_WORKER[self.name]
8787

8888

89-
class Cluster:
89+
class BaseCluster:
9090
"""
9191
Cluster manager for Modin. Knows how to use certain tools to spawn and destroy clusters,
9292
can serve as context manager to switch execution engine and partition to remote.

modin/experimental/cloud/rayscale.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
ConnectionDetails,
3333
_get_ssh_proxy_command,
3434
)
35-
from .cluster import Cluster, Provider
35+
from .cluster import BaseCluster, Provider
3636

3737

3838
class _ThreadTask:
@@ -54,7 +54,7 @@ def join(self):
5454
pass
5555

5656

57-
class RayCluster(Cluster):
57+
class RayCluster(BaseCluster):
5858
__base_config = os.path.join(
5959
os.path.abspath(os.path.dirname(__file__)), "ray-autoscaler.yml"
6060
)

0 commit comments

Comments
 (0)