Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat get budget by second package name paknam2 #2050

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

ougx
Copy link
Contributor

@ougx ougx commented Dec 21, 2023

feat get budget by second package name paknam2

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.1%. Comparing base (1fe5157) to head (61a63e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2050   +/-   ##
=======================================
  Coverage     73.1%   73.1%           
=======================================
  Files          259     259           
  Lines        59511   59513    +2     
=======================================
+ Hits         43510   43516    +6     
+ Misses       16001   15997    -4     
Files Coverage Δ
flopy/utils/binaryfile.py 83.4% <93.0%> (+0.4%) ⬆️

@ougx ougx changed the title fixBug storing correct package names for CellBudgetFile feat get budget by second package name paknam2 Dec 22, 2023
@langevin-usgs
Copy link
Contributor

Hey @ougx, thanks for taking a shot at this! I suspect it is going to take a little more work to get this right and working for all MODFLOW versions. As you probably know, there is not an easy way to get package flows out of the budget file when there are multiple packages of the same type. Do we leave everything the same but support a budobj.get_data(pname="CHD-1") option?

@ougx ougx force-pushed the patch-4 branch 3 times, most recently from fc270e3 to 6871d07 Compare December 22, 2023 18:49
@ougx
Copy link
Contributor Author

ougx commented Mar 7, 2024

@langevin-usgs : there is not an easy way to get package flows out of the budget file when there are multiple packages of the same type. The purpose of this PR is exactly resolve this issue. With the current version, there is no way to extract flux from MVR budget file. Please let me know if you have other suggestions. Thanks!

@langevin-usgs
Copy link
Contributor

@ougx, thanks for this. I added a test and made a small change to the paknam2 docstring. I'll merge when the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants