use a regex instead

43081j · 43081j · commit 363b3ee1c1f1 · 2020-10-31T21:06:38.000Z
a less hacky hack
diff --git a/packages/dev-server-hmr/src/HmrPlugin.ts b/packages/dev-server-hmr/src/HmrPlugin.ts
@@ -90,7 +90,7 @@ export class HmrPlugin implements Plugin {
   /** @inheritDoc */
   async transformImport({ source, context }: { source: string; context: Context }) {
     // Can't possibly handle computed dynamic imports
-    if (source.includes('${')) {
+    if (!/^"[^"]*"|'[^']*'|`[^`]*`/.test(source)) {
       return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ export class HmrPlugin implements Plugin {`
`90`	`90`	`/** @inheritDoc */`
`91`	`91`	`async transformImport({ source, context }: { source: string; context: Context }) {`
`92`	`92`	`// Can't possibly handle computed dynamic imports`
`93`		`- if (source.includes('${')) {`
	`93`	+ if (!/^"[^"]"\|'[^']'\|`[^`]*`/.test(source)) {
`94`	`94`	`return;`
`95`	`95`	`}`
`96`	`96`