Skip to content

Commit 22797cd

Browse files
committed
fix(test-runner-puppeteer): add createBrowserContext
1 parent 245123e commit 22797cd

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.changeset/heavy-items-trade.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@web/test-runner-puppeteer': patch
3+
---
4+
5+
Fixes `createBrowserContext` which previously had no effect and was never called.

packages/test-runner-puppeteer/src/puppeteerLauncher.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,26 @@
11
import * as puppeteer from 'puppeteer';
22
import * as puppeteerCore from 'puppeteer-core';
3-
import { Browser, Page, PuppeteerNodeLaunchOptions } from 'puppeteer-core';
3+
import { Browser, BrowserContext, Page, PuppeteerNodeLaunchOptions } from 'puppeteer-core';
44
import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
55
import { chromeLauncher } from '@web/test-runner-chrome';
66

77
export interface PuppeteerLauncherConfig {
88
launchOptions?: PuppeteerNodeLaunchOptions;
9+
createBrowserContext?: (args: { config: TestRunnerCoreConfig; browser: Browser }) => BrowserContext | Promise<BrowserContext>;
910
createPage?: (args: { config: TestRunnerCoreConfig; browser: Browser }) => Promise<Page>;
1011
concurrency?: number;
1112
}
1213

1314
export function puppeteerLauncher({
1415
launchOptions,
16+
createBrowserContext,
1517
createPage,
1618
concurrency,
1719
}: PuppeteerLauncherConfig = {}): BrowserLauncher {
1820
return chromeLauncher({
1921
launchOptions,
2022
puppeteer: (puppeteer as any).default as typeof puppeteerCore,
23+
createBrowserContext,
2124
createPage,
2225
concurrency,
2326
});

0 commit comments

Comments
 (0)