Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify if in which state discrete variables can be set in CS w/ event mode #1717

Closed
t-sommer opened this issue Mar 14, 2022 · 1 comment · Fixed by #1718
Closed

Clarify if in which state discrete variables can be set in CS w/ event mode #1717

t-sommer opened this issue Mar 14, 2022 · 1 comment · Fixed by #1718
Milestone

Comments

@t-sommer
Copy link
Collaborator

Currently the Spec reads:

Co-Simulation: The value may change at communication points and in Event Mode, if supported.

So it's not clear whether discrete values can change at communication points if Event Mode is used.

On a similar note, does the importer have to enter Event Mode if a non-float value (e.g. a crank speed sensor providing its value as an UInt64) changes?

@KarlWernersson
Copy link
Collaborator

Since we now require CS FMU's to declare if they will use event mode. I don't see it as practical to no enforce event mode for changing discrete values of a CS FMU if it uses event mode, as they are forced to do it for other events.

Integers are discrete values and therefore a change requires event handling. as events are discrete changes.
So if the FMU uses event mode it has to enter event mode each time an integer changes its value.

@andreas-junghanns andreas-junghanns linked a pull request Mar 14, 2022 that will close this issue
@andreas-junghanns andreas-junghanns added this to the v3.0-rc.1 milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants