Add unit="1" to quaternions #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications: * It is the correct unit; as it cannot be anything else. * In many cases we could already deduce the unit for the quaternion based on its derivative. However, if we didn't compute in a specific model the derivative that wouldn't happen. Additionally it seemed a bit counter-intuitive to go that indirect route.
HansOlsson
added
the
L: Mechanics.MultiBody
henrikt-ma
approved these changes
Apr 25, 2024
|
What should I do regarding the CLA-check? |
|
Looks stuck. No idea why. |
|
@casella Can this be backported to maint/4.1.0? No Milestone either |
Please do. |
Esther-Devakirubai
pushed a commit
that referenced
this pull request
Aug 13, 2024
Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications: * It is the correct unit; as it cannot be anything else. * In many cases we could already deduce the unit for the quaternion based on its derivative. However, if we didn't compute in a specific model the derivative that wouldn't happen. Additionally it seemed a bit counter-intuitive to go that indirect route.
|
Backporting this to maintenance branch by #4445 |
casella
pushed a commit
that referenced
this pull request
Aug 13, 2024
Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications: * It is the correct unit; as it cannot be anything else. * In many cases we could already deduce the unit for the quaternion based on its derivative. However, if we didn't compute in a specific model the derivative that wouldn't happen. Additionally it seemed a bit counter-intuitive to go that indirect route. Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Modelica.Mechanics.MultiBody.Frames.Quaternions.der_Orientation already have a corresponding unit. That has two implications:
However, if we didn't compute the derivative in a specific model that deduction wouldn't happen. Additionally it seems a bit counter-intuitive to go that indirect route.