Add a simpler pump #4149
Add a simpler pump #4149
Conversation
|
@sjoelund I don't understand why C-Sources cannot be built for something that didn't change them. |
|
Will look into it ASAP, I'm overbooked now. |
Should work when I rerun it... |
beutlich
added
enhancement
Added (well, copied to be correct). |
Note that this is a protected parameter so it is only shown for base-classes. I decided to have the conditions both as description and as Dialog.enable to make it understandable.
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
| constant SI.Position unitHead = 1; | ||
| constant SI.MassFlowRate unitMassFlowRate = 1; | ||
|
|
||
| parameter Boolean ignoreN = false "= true to ignore N of pump; only use if checkValve=false and use_powerCharacteristic=false" |
There was a problem hiding this comment.
| parameter Boolean ignoreN = false "= true to ignore N of pump; only use if checkValve=false and use_powerCharacteristic=false" | |
| parameter Boolean ignoreN = false "= true, if N of pump is ignored, i.e. N = N_nominal" |
There was a problem hiding this comment.
"only use if checkValve=false and use_powerCharacteristic=false" - we don't use such description to comment the "enable" annotation in other models
There was a problem hiding this comment.
Generally I agree, but I wanted to make an exception here.
Normally if you have enable=animation for an animation-parameter you can intuitively understand the logic and having the explanation would just be silly, but here enable is based on two different parameters that are on different tabs (and I don't want to move them) - and people will basically have to read the source to understand it.
There was a problem hiding this comment.
ok. So simply reject my suggestion.
Closes #2413
As described in #2413 the idea is to have an even simpler Pump when we don't care about N, efficiency and pump characteristics.