Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity name "Relative magnetization" doesn't follow upper camel case convention #4110

Open
henrikt-ma opened this issue Apr 5, 2023 · 1 comment
Assignees
Labels
L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes

Comments

@henrikt-ma
Copy link
Contributor

henrikt-ma commented Apr 5, 2023

This quantity does not follow the MSL convention of using upper camel case names:

output Real MagRel(final quantity="Relative magnetization", final unit="1", start=0, min=-1, max=1)

A more suitable name would be "RelativeMagnetization".

Ideally, the quantity should also be defined in a place like Modelica.Units.SI, where others can find it, to avoid ending up with multiple strings for the same quantity.

@henrikt-ma henrikt-ma added the L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes label Apr 5, 2023
@henrikt-ma
Copy link
Contributor Author

I suppose one could also define quantities on the sub-library level if they are considered too narrow for Modelica.Units, similar to Fluid, for example:

final quantity="HydraulicConductance",

In addition to "RelativeMagnetization", also "MagneticFluxDensitySlope" should be defined in a central location to avoid ending up with many strings for the same quantity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes
Projects
None yet
Development

No branches or pull requests

2 participants