Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to split Modelica.Blocks into single files #3425

Open
christiankral opened this issue Feb 15, 2020 · 4 comments
Open

Proposal to split Modelica.Blocks into single files #3425

christiankral opened this issue Feb 15, 2020 · 4 comments
Assignees
Labels
L: Blocks Issue addresses Modelica.Blocks task General work that is not related to a bug or feature

Comments

@christiankral
Copy link
Contributor

I am asking the library officers @AHaumer and @MartinOtter if they have any intentions to have the package Modelica.Blocks split into single files. In case you agree, it makes sense to have this done before MSL 4.0.0 gets released.

@christiankral christiankral added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks labels Feb 15, 2020
@christiankral christiankral added this to the MSL4.0.0 milestone Feb 15, 2020
@AHaumer
Copy link
Contributor

AHaumer commented Feb 15, 2020

It makes sense, but I'd ask for @MartinOtter 's opinion.

@beutlich beutlich added task General work that is not related to a bug or feature and removed enhancement New feature or enhancement labels Feb 26, 2020
@christiankral
Copy link
Contributor Author

@MartinOtter If you agree, I can prepare a PR to get the package split into individual files. On my opinion the great advantage of single files is, that a GitHub history can directly be created for each Modelica class of the package. This way it is very easy to check what changes have been applied to each Modelica class.

@beutlich beutlich removed this from the MSL4.0.0 milestone Mar 2, 2020
@beutlich
Copy link
Member

beutlich commented Mar 2, 2020

Since there is an open PRs for "Blocks" I am removing the milestone.

@MartinOtter
Copy link
Member

@MartinOtter If you agree, I can prepare a PR to get the package split into individual files. On my opinion the great advantage of single files is, that a GitHub history can directly be created for each Modelica class of the package. This way it is very easy to check what changes have been applied to each Modelica class.

This is fine from my side

christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Blocks Issue addresses Modelica.Blocks task General work that is not related to a bug or feature
Projects
None yet
Development

No branches or pull requests

4 participants