-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename base classes with support flange #3362
Comments
We could rename it to PartialElementaryOneFlangeAndSupport/PartialElementaryTwoFlangesAndSupport (by simply removing the trailing "2"), but then there is some risk that someone using PartialElementaryOneFlangeAndSupport/PartialElementaryTwoFlangesAndSupport from MSL v3.2.3, who uses MSL v4.0.0 without conversion suddenly uses the wrong interface model. |
Here's the commit were the "2" models have been introduced: 68c3c51 |
Why not move non-2 ones to ObsoleteModelica4 and rename the 2-models? That way it should not break the interfaces. |
That's what already happened by 5b13d04. If we now introduce new models with that same name we might risk some name conflicts if conversion is either missed or run twice. |
If we assume a conversion does not take correctly place then we have a whole lot of other problems. It would be strange to workaround that in this case. I'm sure if you look at this like that then we have a number of other cases that also need to be considered. I think it is safe to say that if conversion fails or is not done when using MSL 4.0.0 then user models will break. |
My intension is to give similar names to similar classes. Thus, the package content would be:
I'm aware of the risk by leaving "2" only. This is not what I'm addressing here. |
But there still is PartialElementaryRotationalToTranslational, making it inconsistent. |
Hmm. This is true.
This is a lot more work but is consistent. |
Due to similar model background, the following clases in
Modelica.Mechanics.Rotational.Interfaces
should be renamed:PartialElementaryOneFlangeAndSupport2
toPartialOneFlangeAndSupportElementary
(i.e. a counterpart ofPartialOneFlangeAndSupport
)PartialElementaryTwoFlangesAndSupport2
toPartialTwoFlangesAndSupportElementary
(i.e. a counterpart ofPartialTwoFlangesAndSupport
)May be there is a better option for the supplement instead of "Elementary".
This concerns
Modelica.Mechanics.Translational.Interfaces
accordingly.The text was updated successfully, but these errors were encountered: