Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepances in position, size and color of connectors' names #2481

Open
tobolar opened this issue Mar 2, 2018 · 1 comment
Open

Discrepances in position, size and color of connectors' names #2481

tobolar opened this issue Mar 2, 2018 · 1 comment
Labels
discussion Discussion issue that it not necessarily related to a concrete bug or feature

Comments

@tobolar
Copy link
Contributor

tobolar commented Mar 2, 2018

Connectors within the MSL differ in the position, size and color of their name primitive. In the figure attached, there are shown some of the connectors from different domains.

There should be defined a convention on how to handle the connectors' names, similar to Modelica.UsersGuide.Conventions.Icons. See also discussion on descriptive text in #2471.

connectorsnames

@tobolar tobolar added the discussion Discussion issue that it not necessarily related to a concrete bug or feature label Mar 2, 2018
@christiankral
Copy link
Contributor

I would also prefer to have a consistent way of defining a positive and negative (or what ever their name is) connector by extending from a base connector definitions. This is, however, handled differently in different packages. The base class shall not have an icon. Icons shall be added by the positive and negative connector definitions.

Example 1: Modelica.Mechanics.Rotational.Interfaces

  • Flange_a is defined without extending from a base defintion
  • Flange_b is defined without extending from a base defintion
connector Flange_a "One-dimensional rotational flange of a shaft (filled circle icon)"
  SI.Angle phi "Absolute rotation angle of flange";
  flow SI.Torque tau "Cut torque in the flange";
end Flange_a;

Example 2: Modelica.Electrical.MultiPhase.Interfaces:

  • PositivePlug extends from Plug
  • NegativePlug extends from Plug
  • Plug contains the base definition of the potential and flow variable
connector Plug "Plug with m pins for an electric component"
  parameter Integer m(final min=1) = 3 "Number of phases";
  Modelica.Electrical.Analog.Interfaces.Pin pin[m];
end Plug;
connector PositivePlug "Positive plug with m pins"
  extends Plug;
end PositivePlug;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion issue that it not necessarily related to a concrete bug or feature
Projects
None yet
Development

No branches or pull requests

2 participants