Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler Modelica.Fluid.Machines.ControlledPump #2413

Open
HansOlsson opened this issue Jan 2, 2018 · 0 comments · May be fixed by #4149
Open

Simpler Modelica.Fluid.Machines.ControlledPump #2413

HansOlsson opened this issue Jan 2, 2018 · 0 comments · May be fixed by #4149
Assignees
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)

Comments

@HansOlsson
Copy link
Contributor

HansOlsson commented Jan 2, 2018

The model has the comment "Use this model if the pump characteristics is of secondary interest."

However, even if the values for the pump characteristic as default has zero impact on the rest of the model (as far as I can see) incorrect values will still lead to a failed simulation.

This is slightly complicated - but as far as I can see:
For the default case N will be determined from head, and eta a fixed value so that power consumption does in fact not depend on the speed.
The equation for N is complicated, but even for a linear flow characteristic it is a quadratic equation that cannot be solved for all values of head (seems it is a minimum allowed value).
Values below the minimum may be non-physical - but a proper warning/error is preferable to having a non-linear system that cannot be solved.

Assuming this is correct I would propose to introduce a simpler variant of ControlledPump (either as parameter or as a separate model) without 'N'; possibly with monitoring for this issue.

To clarify: the simpler variant will simulate in more cases than the current one; and produce the same results when both work - and can be made by "just disabling N and its equations".

@HansOlsson HansOlsson added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jan 2, 2018
HansOlsson added a commit to HansOlsson/Modelica that referenced this issue Jun 13, 2023
@HansOlsson HansOlsson linked a pull request Jun 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants