Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table test data of ModelicaTest should not be stored in the MSL #1299

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 5 comments
Closed

Table test data of ModelicaTest should not be stored in the MSL #1299

modelica-trac-importer opened this issue Jan 14, 2017 · 5 comments
Assignees
@dietmarw
Labels
bug Critical/severe issue L: Resources Issue addresses Modelica/Resources (excl. C-Sources) wontfix Issue that will not be fixed
Milestone
never

Comments

@modelica-trac-importer
Copy link

Reported by dietmarw on 1 Oct 2013 10:57 UTC
The ModelicaTest examples link to test data files *.mat which are stored inside

Modelica/Resources/Data/Tables

Since these are test data files from the ModelicaTest library these really ought to be moved to
ModelicaTest/Resources/Data/Tables

Migrated-From: https://trac.modelica.org/Modelica/ticket/1299
@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.2 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Resources Issue addresses Modelica/Resources (excl. C-Sources) labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 25 Oct 2013 21:27 UTC
FIXED in a304125: Moving test table data files into ModelicaTest

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 28 Oct 2013 09:42 UTC
Change is non-backward compatible.

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 28 Oct 2013 09:43 UTC
Change is reverted in 86c27c9 and can not really be fixed currently. See also #1339 for a follow up.

@modelica-trac-importer modelica-trac-importer added the wontfix Issue that will not be fixed label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 6 Oct 2015 09:24 UTC

Open
@HansOlsson
Copy link
Contributor

To me there are two parts here:

  1. The general need for renaming resources: I agree that this will need something more for conversion scripts.
  2. This specific case: Since the resources are test-resources, I would argue that they can be changed without the need for conversion scripts - similarly as modifying the examples without conversions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dietmarw dietmarw

Labels
bug Critical/severe issue L: Resources Issue addresses Modelica/Resources (excl. C-Sources) wontfix Issue that will not be fixed
Projects
None yet
Milestone
never
Development

No branches or pull requests
3 participants
@dietmarw @HansOlsson @modelica-trac-importer