feat: eslint rule to prefer node protocols (#1187)

Author: mattzcarey

eslint.config.mjs

@@ -3,6 +3,7 @@
 import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
 import eslintConfigPrettier from 'eslint-config-prettier/flat';
+import nodePlugin from 'eslint-plugin-n';
 
 export default tseslint.config(
     eslint.configs.recommended,
@@ -11,8 +12,12 @@ export default tseslint.config(
         linterOptions: {
             reportUnusedDisableDirectives: false
         },
+        plugins: {
+            n: nodePlugin
+        },
         rules: {
-            '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }]
+            '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+            'n/prefer-node-protocol': 'error'
         }
     },
     {

package-lock.json

@@ -126,6 +126,7 @@
         "@typescript/native-preview": "^7.0.0-dev.20251103.1",
         "eslint": "^9.8.0",
         "eslint-config-prettier": "^10.1.8",
+        "eslint-plugin-n": "^17.23.1",
         "prettier": "3.6.2",
         "supertest": "^7.0.0",
         "tsx": "^4.16.5",

package.json

@@ -1,5 +1,5 @@
-import { createServer, ServerResponse, type IncomingMessage, type Server } from 'http';
-import { AddressInfo } from 'net';
+import { createServer, ServerResponse, type IncomingMessage, type Server } from 'node:http';
+import { AddressInfo } from 'node:net';
 import { JSONRPCMessage } from '../types.js';
 import { SSEClientTransport } from './sse.js';
 import { OAuthClientProvider, UnauthorizedError } from './auth.js';

src/client/sse.test.ts

@@ -7,7 +7,7 @@
 
 import { Task, Request, RequestId, Result } from '../../../types.js';
 import { TaskStore, isTerminal, TaskMessageQueue, QueuedMessage, CreateTaskOptions } from '../interfaces.js';
-import { randomBytes } from 'crypto';
+import { randomBytes } from 'node:crypto';
 
 interface StoredTask {
     task: Task;

src/experimental/tasks/stores/in-memory.ts

@@ -1,4 +1,4 @@
-import http from 'http';
+import http from 'node:http';
 import { type Mocked } from 'vitest';
 
 import { SSEServerTransport } from './sse.js';

src/server/sse.test.ts

@@ -5,7 +5,7 @@ import { JSONRPCMessage, JSONRPCMessageSchema, MessageExtraInfo, RequestInfo } f
 import getRawBody from 'raw-body';
 import contentType from 'content-type';
 import { AuthInfo } from './auth/types.js';
-import { URL } from 'url';
+import { URL } from 'node:url';
 
 const MAXIMUM_MESSAGE_SIZE = '4mb';