Skip to content

fix: fix missing seed.json on startup by renaming file #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chenmingyong0423
Copy link
Contributor

@chenmingyong0423 chenmingyong0423 commented May 26, 2025

Renamed data/seed_2025_05_16.json to data/seed.json and updated Dockerfile

Motivation and Context

When cloning the repository and building the project using:

go build ./cmd/registry
.\\registry.exe

the application fails to start because the default seed file path (data/seed.json) does not exist in the repo:

Failed to read seed file: failed to read file: open data/seed.json: The system cannot find the file specified.

How Has This Been Tested?

go build ./cmd/registry
.\\registry.exe // ./registry

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@yshngg
Copy link
Contributor

yshngg commented May 26, 2025

Hi @chenmingyong0423 , why not simply rename the seed_2025_05_16.json file to seed.json?

@chenmingyong0423
Copy link
Contributor Author

@yshngg The current seed file is named seed_2025_05_16.json, and I wasn’t sure if there’s a specific versioning or naming convention behind it. To avoid unintentionally breaking that design decision, I chose to update the config and Docker setup to match the existing file rather than renaming it to seed.json.

@yshngg
Copy link
Contributor

yshngg commented May 26, 2025

@chenmingyong0423 I understand your point, but I think this PR might reduce flexibility. The current seed file is named seed_2025_05_16.json. If updates are made later and a new file like seed_2025_05_26.json is created, we would need to update the default path to import seed file again.

If we don't create new seed files, what's the difference between filenames seed_2025_05_16.json and seed.json?

@chenmingyong0423
Copy link
Contributor Author

@yshngg I actually agree that renaming seed_2025_05_16.json to seed.json would be a cleaner and simpler solution. However, I'm not sure if there was any specific reason or versioning intent behind the original filename. If not, standardizing it as seed.json makes perfect sense. Looking forward to hearing the maintainers’ thoughts.

@chenmingyong0423
Copy link
Contributor Author

chenmingyong0423 commented May 26, 2025

@yshngg I'd like to check — are you the main reviewer or maintainer of this project? If so, I’m happy to adjust the PR based on your suggestions.

@chenmingyong0423
Copy link
Contributor Author

@yshngg It looks like you're the main reviewer or maintainer — I’ve updated the changes according to your suggestions. Thanks for the input!

@chenmingyong0423 chenmingyong0423 changed the title fix: Update default SeedFilePath to existing seed file Fix missing seed.json on startup by renaming file and updating Dockerfile May 26, 2025
@yshngg
Copy link
Contributor

yshngg commented May 26, 2025

@yshngg I'd like to check — are you the main reviewer or maintainer of this project? If so, I’m happy to adjust the PR based on your suggestions.

Oops, sorry for the confusion — I'm just interested in the project and not a reviewer or maintainer.

@chenmingyong0423
Copy link
Contributor Author

@yshngg I'd like to check — are you the main reviewer or maintainer of this project? If so, I’m happy to adjust the PR based on your suggestions.

Oops, sorry for the confusion — I'm just interested in the project and not a reviewer or maintainer.

Alright!

@chenmingyong0423 chenmingyong0423 changed the title Fix missing seed.json on startup by renaming file and updating Dockerfile fix: fix missing seed.json on startup by renaming file May 27, 2025
@mukteshkrmishra
Copy link

This is actually nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants