-
Notifications
You must be signed in to change notification settings - Fork 99
fix: fix missing seed.json on startup by renaming file #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: fix missing seed.json on startup by renaming file #75
Conversation
Hi @chenmingyong0423 , why not simply rename the |
@yshngg The current seed file is named seed_2025_05_16.json, and I wasn’t sure if there’s a specific versioning or naming convention behind it. To avoid unintentionally breaking that design decision, I chose to update the config and Docker setup to match the existing file rather than renaming it to seed.json. |
@chenmingyong0423 I understand your point, but I think this PR might reduce flexibility. The current seed file is named If we don't create new seed files, what's the difference between filenames |
@yshngg I actually agree that renaming seed_2025_05_16.json to seed.json would be a cleaner and simpler solution. However, I'm not sure if there was any specific reason or versioning intent behind the original filename. If not, standardizing it as seed.json makes perfect sense. Looking forward to hearing the maintainers’ thoughts. |
@yshngg I'd like to check — are you the main reviewer or maintainer of this project? If so, I’m happy to adjust the PR based on your suggestions. |
…rt config default
@yshngg It looks like you're the main reviewer or maintainer — I’ve updated the changes according to your suggestions. Thanks for the input! |
Oops, sorry for the confusion — I'm just interested in the project and not a reviewer or maintainer. |
Alright! |
This is actually nice. |
Renamed
data/seed_2025_05_16.json
todata/seed.json
and updatedDockerfile
Motivation and Context
When cloning the repository and building the project using:
go build ./cmd/registry .\\registry.exe
the application fails to start because the default seed file path (
data/seed.json
) does not exist in the repo:How Has This Been Tested?
go build ./cmd/registry .\\registry.exe // ./registry
Breaking Changes
None
Types of changes
Checklist
Additional context