refactor: replace Handler objects with on_* constructor kwargs #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the RequestHandler/NotificationHandler wrapper classes with direct on_* keyword arguments on the Server constructor. Handlers are now raw callables stored in internal dicts keyed by method string. - Delete handler.py (Handler, RequestHandler, NotificationHandler) - Server constructor takes on_list_tools, on_call_tool, etc. instead of handlers: Sequence[Handler] - Add _add_request_handler / _add_notification_handler for post-construction registration (used by ExperimentalHandlers and MCPServer completion) - Remove RequestT generic from Server — the request context type is transport-specific and not known at construction time - Type ServerMessageMetadata.request_context as Any (transport-agnostic) - Update ExperimentalHandlers to use RequestContext[ServerSession, Any, Any] - Update MCPServer to pass on_* kwargs via _create_handler_kwargs()
… removal - Remove func_inspection.py which is no longer imported after decorator removal - Add migration note about jsonschema input/output validation being removed from the lowlevel Server's call_tool handler with no built-in replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
RequestHandler/NotificationHandlerwrapper classes with directon_*keyword arguments on the lowlevelServerconstructor.Changes
handler.py—Handler,RequestHandler,NotificationHandlerclasses removed entirelyon_list_tools,on_call_tool, etc. instead ofhandlers: Sequence[Handler]. Handlers are raw callables with(ctx, params) -> resultsignature_add_request_handler/_add_notification_handlerfor post-construction registration (used by ExperimentalHandlers and MCPServer completion decorator)RequestTgeneric fromServer— the request context type is transport-specific and not known at construction time, so it was never properly bound as a genericServerMessageMetadata.request_contextasAny— transport-agnosticExperimentalHandlersto useRequestContext[ServerSession, Any, Any]and the new callback-based registrationMCPServerto passon_*kwargs via_create_handler_kwargs()func_inspection.py— no longer imported after decorator removalNot included
Tests, examples, and README updates — these were already broken on the base branch before these changes.