Add regression tests for #559 and #555 #1044
Draft
+164
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
force-pushed
the
fweinberger/stream-cleanup-only-approach
branch
from
1ab6f36 to
9f88ea7
Compare
felixweinberger
force-pushed
the
fweinberger/stream-cleanup-only-approach
branch
from
9f88ea7 to
a27fcef
Compare
9 tasks
felixweinberger
force-pushed
the
fweinberger/stream-cleanup-only-approach
branch
3 times, most recently
from
785386a to
543e1ad
Compare
**NOTE: These tests FAIL without the changes introduced in #559** - test_stdio_client_universal_timeout - test_stdio_client_immediate_completion await read_stream.aclose() await write_stream.aclose() await read_stream_writer.aclose() await write_stream_reader.aclose() These tests verify that stdio_client completes cleanup within reasonable time for both slow-terminating and fast-exiting processes, preventing the hanging issues reported in #559. **NOTE: This test FAILS without the changes introduced in #555** - test_stdio_client_sigint_only_process try: process.terminate() with anyio.fail_after(2.0): await process.wait() except TimeoutError: # If process doesn't terminate in time, force kill it process.kill() This test verifies that on UNIX systems MCP servers that don't respect SIGTERM but e.g. SIGINT still get terminated after a grace period.
felixweinberger
force-pushed
the
fweinberger/stream-cleanup-only-approach
branch
2 times, most recently
from
98012bf to
caa5628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#559 and #555 address important but different ways MCP servers can hang if they don't respect SIGTERM or SIGINT.
This PR adds regressions tests to clearly demonstrate the edge cases addressed by #559 and #555.
How Has This Been Tested?
See tests introduced in the 2nd commit.
I reverted the changes in both #555 and #559 to verify that all 3 tests FAIL without them:
#559 makes the first 2 tests pass, but not the third (because it doesn't solve SIGINT):
#555 also makes the third test pass (no test for Windows because signals handled differently, so this test is skipped on Windows)
I ran the tests on both macOS and Windows.
Breaking Changes
None.
Types of changes
Checklist
Additional context