Skip to content

Remove fixed suffix /sse #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamglin0
Copy link
Contributor

@adamglin0 adamglin0 commented May 31, 2025

Remove the hardcoded /sse string in the sse client transport, which forcibly adds /sse to the path, making it very crude.

When using all sse mcp servers, it's almost always in the format like http://localhost:3000/sse, and the forced addition of /sse leads to errors. In (npx @modelcontextprotocol/inspector), users also need to manually add the /sse suffix.

Motivation and Context

How Has This Been Tested?

Breaking Changes

If this PR is merged, consumers must manually add the /sse suffix to their URL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@StefMa
Copy link
Contributor

StefMa commented May 31, 2025

This is an breaking change!
Consumers might relay on /sse suffix.
They can easily fix it, but they have to be aware of it.

@Mervap
Copy link

Mervap commented Jun 17, 2025

This is indeed a breaking change, but the current assumption simply doesn’t work for some MCP implementations.
A major version bump would clearly indicate that the release may include breaking changes

Please approve this PR, as it’s currently nearly impossible to use the client with servers that don’t end with /sse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants