Reorder StdioServerTransport shutdown procedure to avoid errors#7
Merged
Reorder StdioServerTransport shutdown procedure to avoid errors#7
Conversation
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the tests occasionally the STDIO variant would fail due to dropped errors.
Motivation and Context
When exercising the
StdioMcpSyncServerTestsoccasionallyonErrorDroppedsignals would be logged signifying that the shutdown of the inbound is not properly ordered with regards to the outbound and the outbound-relatedScheduleris shutdown before the pipeline has a chance to process the completion signal.How Has This Been Tested?
./mvnw clean installBreaking Changes
No.
Types of changes
Checklist
Additional context
None