Skip to content

docs: update loggingNotification javadoc to specify single client #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

LucaButBoring
Copy link
Contributor

Fixes the Javadoc comments on loggingNotification in the exchange classes to specify that only the client on the exchange will receive the notification.

Motivation and Context

The loggingNotification methods on the exchange classes incorrectly state that notifications are sent to all clients, which is only the case for the deprecated methods on the server instances.

How Has This Been Tested?

N/A

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@tzolov
Copy link
Contributor

tzolov commented Jun 23, 2025

LGTM

@tzolov tzolov self-assigned this Jun 23, 2025
@tzolov tzolov added the documentation Improvements or additions to documentation label Jun 23, 2025
@tzolov tzolov added this to the 0.11.0 milestone Jun 23, 2025
@tzolov tzolov merged commit 0fe76ba into modelcontextprotocol:main Jun 23, 2025
1 check passed
@LucaButBoring LucaButBoring deleted the docs/logging branch June 23, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants