fix: make toolInfo.id optional per spec #216
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec (apps.mdx) defines toolInfo.id as optional (id?: RequestId), but the TypeScript types and generated schemas had it as required. This allows hosts to pass just the tool definition without needing a request ID, which is useful when the tool name is the primary information needed by the widget.
commit: |
ochafik
approved these changes
Jan 8, 2026
Merged
ochafik
added a commit
that referenced
this pull request
Jan 9, 2026
Merge latest changes from main including: - Vue, Svelte, Preact, and Solid basic server examples (#141) - safeAreaInsets support (#202) - E2E test fixes (#206) - npm publishing for examples (#184) - ui.resourceUri optional (#210) - Method names as consts (#192) - toolInfo.id optional (#216) - PostMessageTransport security fixes (#207, #208) - Server-utils.ts refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the TypeScript types and generated Zod schemas with the specification.
Changes
The spec (apps.mdx line 444) defines
toolInfo.idas optional:However, the implementation had it as required. This PR fixes the mismatch.
Why this matters
This allows hosts to pass just the tool definition without needing a request ID, which is useful when the widget only needs to know which tool was called (e.g., for custom loading screens per tool type).