fix: add mimeType to resource declarations in examples #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to spec, mimeType should be present in both the resource declaration and the resource content. This adds the missing mimeType to the registerResource() declaration (third parameter) in all example servers and the quickstart documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
antonpk1
force-pushed
the
fix/add-mimetype-to-resource-declarations
branch
from
528f314 to
98db6a6
Compare
commit: |
…esource-declarations # Conflicts: # examples/basic-server-react/server.ts # examples/basic-server-vanillajs/server.ts # examples/budget-allocator-server/server.ts # examples/customer-segmentation-server/server.ts # examples/scenario-modeler-server/server.ts
ochafik
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mimeTypeto the resource declaration (third parameter ofregisterResource()) in all 9 example serversBackground
According to the spec,
mimeTypeshould be present in both:ReadResourceResult)Previously,
mimeTypewas only present in the resource content but missing from the resource declaration.Test plan
npm run build:all🤖 Generated with Claude Code