Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: modelcontextprotocol/csharp-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: modelcontextprotocol/csharp-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-outgoing-filter-test
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 2 contributors

Commits on Apr 1, 2026

  1. Fix flaky OutgoingFilter_MultipleFilters_ExecuteInOrder test 

    The outermost filter's 'after' callback runs after the response has been
sent to the client via next(). In stateless/SSE mode, ListToolsAsync can
return before the server-side filter pipeline finishes executing the
'after' callbacks. Assert.Equal then enumerates the executionOrder list
concurrently with the filter adding to it, causing 'Collection was
modified' InvalidOperationException.

Fix by waiting for the outermost filter's 'after' callback to signal
completion before asserting on the execution order.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    @ericstj
    ericstj and Copilot committed Apr 1, 2026
    Configuration menu
    Copy the full SHA
    b6efae1 View commit details
    Browse the repository at this point in the history
Loading