Skip to content

Conversation

@karkhaz
Copy link
Contributor

@karkhaz karkhaz commented Apr 26, 2023

This commit adds an out_file to the benchcomp visualizes that emit output (currently just one visualization, dump_yaml). This is to allow different visualizations to be written to different output files, including stdout.

The intention (for a future commit) is that CI will save certain visualizations as artifacts, which users can then download.

Testing:

  • How is this change tested? Ran it locally

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@karkhaz karkhaz requested a review from a team as a code owner April 26, 2023 16:24
@karkhaz karkhaz force-pushed the kk-out-file branch 3 times, most recently from 8f70914 to a477914 Compare April 26, 2023 16:32
@karkhaz karkhaz enabled auto-merge (squash) April 26, 2023 18:17
@tautschnig
Copy link
Member

This is not currently possible because the Action will fail if there were any regressions, meaning that the artifact would not be subsequently uploaded. This will be addressed in a future commit that allows particular visualizations to run.

I don't think this statement is true: https://github.com/actions/upload-artifact will happily upload artifacts even if an earlier step failed (there even is provision to only do so when an earlier step failed, see their docs). We make good use of this in https://github.com/diffblue/cbmc/blob/develop/.github/workflows/build-and-test-Linux.yaml, which will upload files to debug build failures.

This commit adds an `out_file` to the benchcomp visualizes that emit
output (currently just one visualization, dump_yaml). This is to allow
different visualizations to be written to different output files,
including stdout.

The intention (for a future commit) is that CI will save certain
visualizations as artifacts, which users can then download.
@karkhaz karkhaz disabled auto-merge April 27, 2023 12:53
@karkhaz karkhaz enabled auto-merge (squash) April 27, 2023 12:53
@karkhaz
Copy link
Contributor Author

karkhaz commented Apr 27, 2023

You're right, thank you. I've amended the commit message.

@karkhaz karkhaz merged commit 6f57d12 into model-checking:main Apr 27, 2023
@karkhaz karkhaz deleted the kk-out-file branch April 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants