-
Notifications
You must be signed in to change notification settings - Fork 130
Allow excluding packages from verification with --exclude
#2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zhassan-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adpaco-aws!
because it doesn't require --workspace (but it's implied anyway)
I'd prefer if we make --workspace required to keep the same interface as cargo build/test.
Thanks, it's required now. |
Description of changes:
This PR adds a
--excludeoption to Kani and allows excluding packages from verification (requested in #2375). It also adds validation for the packages passed to--packageand--excludeso we print a user-friendly error with all unknown packages, instead of usingexpectas we were doing for arguments to--package.Resolved issues:
Resolves #2375
Testing:
How is this change tested? Existing tests + 4 new ones.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.