Fixing bug with arrays, it was appending new values instead of replacing them

Author: Edwin Cruz

lib/setting.rb

@@ -5,7 +5,7 @@ class Hash
   def recursive_merge!(other)
     other.keys.each do |k|
       if self[k].is_a?(Array) && other[k].is_a?(Array)
-        self[k] += other[k]
+        self[k] = other[k]
       elsif self[k].is_a?(Hash) && other[k].is_a?(Hash)
         self[k].recursive_merge!(other[k])
       else

mc-settings.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{mc-settings}
-  s.version = "0.1.0"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Edwin Cruz", "Colin Shield"]
-  s.date = %q{2010-12-28}
+  s.authors = ["Edwin Cruz", "Konstantin Gredeskoul"]
+  s.date = %q{2011-01-18}
   s.description = %q{implement custom keys indenendently of environment}
   s.email = %q{rubydev@modcloth.com}
   s.extra_rdoc_files = [
@@ -27,6 +27,7 @@ Gem::Specification.new do |s|
     "lib/mc-settings.rb",
     "lib/setting.rb",
     "mc-settings.gemspec",
+    "spec/fixtures/joes-colors.yml",
     "spec/fixtures/sample.yml",
     "spec/mc_settings_spec.rb",
     "spec/spec_helper.rb",

spec/mc_settings_spec.rb

@@ -52,6 +52,12 @@
     it "should create keys if it does not exist" do
       Setting.test_specific.should == "exist"
     end
+
+    context "working with arrays" do
+      it "should replace the whole array instead of appending new values" do
+        Setting.nested_array.should == ['first', 'four', 'five']
+      end
+    end
   end
 
   context "When running with threads" do

spec/support/settings_helper.rb

@@ -20,6 +20,10 @@ def stub_setting_files
       default: 7
     flag_false:
       default: false
+    nested_array:
+      - first
+      - second
+      - third
 CONTENT
   test = <<-CONTENT
     one: test
@@ -30,6 +34,10 @@ def stub_setting_files
     six:
       extra: "recursively overriden"
     test_specific: "exist"
+    nested_array:
+      - first
+      - four
+      - five
   CONTENT
 
   empty = <<-CONTENT