This repository was archived by the owner on Jan 18, 2021. It is now read-only.
Fixed GitHub authorization#871
Merged
Merged
Conversation
As GitHub will support authentication through query parameters no more, it is needed to move authentication to the connection header. It was done in GitHubListFetcher and GitHubObjectFetcher classes. After this there was a necessity to refactor GitHubContributorsFetcher, RecentContributorsFetcher and GitHubTicketFetcher classes.
In order to avoid conditional complexity 'if' statement was removed and authorization token was moved to a field and assigned in the constructor.
koral--
approved these changes
Jun 26, 2020
Member
|
I'm going to merge it because I cannot reproduce the failure locally so I think it's a red herring. The change is useful and avoid deprecation of GitHub API. |
shardulm94
added a commit
to linkedin/coral
that referenced
this pull request
Oct 29, 2020
Remove shipkit's dependence on a now deprecated Github API which will stop working in March 2021 (was October 2020 previously) mockito/shipkit#871 Tested by running ./gradlew performRelease -PdryRun locally
funcheetah
pushed a commit
to linkedin/coral
that referenced
this pull request
Nov 18, 2020
Remove shipkit's dependence on a now deprecated Github API which will stop working in March 2021 (was October 2020 previously) mockito/shipkit#871 Tested by running ./gradlew performRelease -PdryRun locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub will no longer support authentication through query parameters (reported in issue #864; more info: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters, https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/).
To deal with this issue there was a need to move authentication to the connection header.
It was done in GitHubListFetcher and GitHubObjectFetcher classes. Followed by this refactor there was also a necessity to refactor GitHubContributorsFetcher, RecentContributorsFetcher and
GitHubTicketFetcher classes.