Skip to content
This repository was archived by the owner on Jan 18, 2021. It is now read-only.

Spec for discussing future of Shipkit#861

Merged
mockitoguy merged 1 commit into
masterfrom
sf2
Mar 22, 2020
Merged

Spec for discussing future of Shipkit#861
mockitoguy merged 1 commit into
masterfrom
sf2

Conversation

@mockitoguy

Copy link
Copy Markdown
Member

@mockito/shipkit-developers, any thoughts?

@codecov

codecov Bot commented Feb 9, 2020

Copy link
Copy Markdown

Codecov Report

Merging #861 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #861      +/-   ##
============================================
+ Coverage     76.38%   76.51%   +0.12%     
- Complexity     1235     1253      +18     
============================================
  Files           221      221              
  Lines          4502     4534      +32     
  Branches        336      340       +4     
============================================
+ Hits           3439     3469      +30     
- Misses          950      951       +1     
- Partials        113      114       +1
Impacted Files Coverage Δ Complexity Δ
...rg/shipkit/internal/exec/DefaultProcessRunner.java 89.77% <0%> (+2.27%) 36% <0%> (+18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f9d43...5920c36. Read the comment docs.

@koral-- koral-- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epeee

epeee commented Feb 9, 2020

Copy link
Copy Markdown
Contributor

👍, thx!

@mockitoguy

Copy link
Copy Markdown
Member Author

I'll keep it open for 1-2 weeks to collect more feedback.

Thanks for review!

@mockitoguy mockitoguy changed the title Added spec for discussing future of Shipkit Spec for discussing future of Shipkit Feb 10, 2020
@LunNova

LunNova commented Feb 19, 2020

Copy link
Copy Markdown

adoption is small (too opinionated? / too complicated?).

a little of that, but also you're missing out on expensive consultants pushing people to move to it as a way to generate work

Not that it means much, but shipkit's saved a lot of time here and very happy that it exists.

@mockitoguy

Copy link
Copy Markdown
Member Author

@nallar, thank you for feedback!

@mockitoguy mockitoguy merged commit ae1c8f3 into master Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants