This repository was archived by the owner on Jan 18, 2021. It is now read-only.
Add documentation how to ship with maven-publish plugin fixes #768#832
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=========================================
Coverage 76.78% 76.78%
Complexity 1227 1227
=========================================
Files 219 219
Lines 4454 4454
Branches 333 333
=========================================
Hits 3420 3420
Misses 922 922
Partials 112 112Continue to review full report at Codecov.
|
koral--
reviewed
Jul 12, 2019
|
|
||
| #### Nitty gritty | ||
|
|
||
| Applying "[org.shipkit.java](https://plugins.gradle.org/plugin/org.shipkit.java)" Gradle plugin will automatically apply "[org.shipkit.bintray](https://plugins.gradle.org/plugin/org.shipkit.bintray) plugin what is not expected in this case. |
Member
There was a problem hiding this comment.
This dobule quote: "[org.shipkit.bintray] is not closed anywhere.
Additionally, looking at this diff and nearby lines it seems more consistent to not enclose any clickable links in double quotes.
koral--
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.