Introduce static singleton object spying with real-method-call and strict-stub default behaviour #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarrenBishop
force-pushed
the
feature/Introduce_object_spying_for_call_real_method_default_behaviour
branch
from
d59747f to
765aa3a
Compare
DarrenBishop
force-pushed
the
feature/Introduce_object_spying_for_call_real_method_default_behaviour
branch
2 times, most recently
from
8ba0a2c to
00a51cf
Compare
ultrasecreth
requested changes
Aug 6, 2021
scalatest/src/test/scala/user/org/mockito/MockitoScalaSessionTest.scala
Outdated
Show resolved
Hide resolved
DarrenBishop
force-pushed
the
feature/Introduce_object_spying_for_call_real_method_default_behaviour
branch
3 times, most recently
from
3521617 to
79f92a4
Compare
ultrasecreth
approved these changes
Aug 15, 2021
Member
|
@DarrenBishop pls rebase, the HEAD of the release/1.x branch has the fix for CI |
…ion.properties` file, when referencing this project i.e. `mockito-scala`, from another project in the developer's workspace
1. Includes auto-verification within a session for unnecessary stubs; strictness is applied by default via implicits 2. Proof that real methods are called when not stubbed
…; `sbt test` runs green locally.
DarrenBishop
force-pushed
the
feature/Introduce_object_spying_for_call_real_method_default_behaviour
branch
from
79f92a4 to
79c97ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
withObjectSpied[...]works almost the same aswithObjectMocked[...]e.g. they are both strict by default, but with the following differences:Static singleton objects are already complete w.r.t to implementation, so the behaviour proposed here is for real methods to be called; this allows slight tweaks in its original behaviour, rather than having to reimplement in stubs.
Otherwise,
withObjectMocked[...]can still be used.Leniency settings are made available via an implicit parameters, with strict semantics enabled by default i.e. implicitly.
I did want to spend more time looking into some leniency-related enums I saw during this work, but thought get the PR out sooner rather than later, as it currently works.
@bbonanno do you think there is some de-duplication that can be done in this area?
Finally re: the version parsing, I wanted to try these changes on some code I am working on for my client;
publishLocalis annoying development-loop, when working across projects. I tried to use the following in my clientbuild.sbt:This however lead to errors locating the
version.propertiesfile; the changes seem to fix that. I can remove if it is considered undesirable, give also the creation ofproject/Helpers.scala