Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate ESLint config to flat config #5060

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 28, 2023

PR Checklist

Overview

Migrates from the old .eslintrc.yml to a new eslint.config.js per the new ESLint flat config. Applies a few touchups in the process:

Intentionally doesn't extend from eslint:recommended, as that change is likely to cause a lot more noise. I split that out into #5061.

@coveralls
Copy link

coveralls commented Dec 28, 2023

Coverage Status

coverage: 94.335%. remained the same
when pulling 5976e7c on JoshuaKGoldberg:eslint-config-flat
into 53a4baf on mochajs:master.

Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into this, it's on my todo to do for standard

Copy link
Member

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a merge conflict in package-lock.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8317f90 into mochajs:master Feb 9, 2024
25 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-config-flat branch February 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Repo: Rework ESLint config: flat config, separate Prettier plugin
4 participants