-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report skipped tests upon beforeAll hook failure #4221
base: main
Are you sure you want to change the base?
Conversation
acf8687
to
3b59dd8
Compare
3b59dd8
to
9bcd7fc
Compare
a85e55f
to
9febfaf
Compare
9febfaf
to
989fae1
Compare
989fae1
to
06fc1d0
Compare
I'm confused about this vs. #4223 |
@boneskull I don't know if this is actually much different then that issue described, but I forced failure at a beforeEach statement. I got no other pending or skipped test cases for the tests omitted after the failure while using Mocha 8.1.1 |
Any update on this? would be really helpful for multiple e2e testing workflows. |
Any updates on this? Could really use this update. |
Per #1815 (comment), marking this and #4223 as |
Description
related: #4233
Before: a failing
before
hook ignores the three tests completely. They disappear and are not even summarised in the epilogue.After:
Description of the Change
EVENT_TEST_SKIPPED
test.state
:skipped
pending
test cases, but in color red.We now have four test states:
passes
pending
: set by the userit('some test')
it.skip()
ordescribe.skip()
this.skip()
skipped
: test not run because of a failing hookfailed
: test failed or hook failedWe are aware of
pending
not being an optimal label. Nevertheless we will stick to it for historical reasons, it has been established for many years.Applicable issues
ToDo:
afterEach
hooks#1955
#1815