-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
further build improvements #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cache npm itself - use `npm ci` - cache the npm cache - ignore scripts when installing unless necessary - cache `node_modules` for `npm install`-using smoke tests - prefer flags over env vars Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
boneskull
added
qa
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
labels
Apr 7, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
This reverts commit 3f593d6.
outsideris
approved these changes
Apr 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Oct 2, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
- cache npm itself - use `npm ci` - cache the npm cache - ignore scripts when installing unless necessary - cache `node_modules` for `npm install`-using smoke tests - prefer flags over env vars Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm ci
node_modules
fornpm install
-using smoke tests