-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add working wallaby config #3224
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
'use strict'; | ||
|
||
module.exports = () => { | ||
return { | ||
files: [ | ||
'index.js', 'lib/**/*.js', 'test/setup.js', | ||
{ | ||
pattern: 'test/node-unit/**/*.fixture.js', | ||
instrument: false | ||
}, { | ||
pattern: 'test/unit/**/*.fixture.js', | ||
instrument: false | ||
} | ||
], | ||
filesWithNoCoverageCalculated: ['test/**/*.fixture.js'], | ||
tests: [ | ||
'test/unit/**/*.spec.js', 'test/node-unit/**/*.spec.js' | ||
], | ||
env: { | ||
type: 'node', | ||
runner: 'node' | ||
}, | ||
workers: {recycle: true}, | ||
testFramework: {type: 'mocha', path: __dirname}, | ||
setup (wallaby) { | ||
// running mocha instance is not the same as mocha under test, | ||
// running mocha is the project's source code mocha, mocha under test is instrumented version of the source code | ||
const runningMocha = wallaby.testFramework; | ||
runningMocha.timeout(200); | ||
// to expose it/describe etc. on the mocha under test | ||
const mochaUnderTest = new (require('./'))(); | ||
mochaUnderTest.suite.emit('pre-require', global, '', mochaUnderTest); | ||
// to make test/node-unit/color.spec.js pass, we need to run mocha in the project's folder context | ||
const childProcess = require('child_process'); | ||
const execFile = childProcess.execFile; | ||
childProcess.execFile = function () { | ||
let opts = arguments[2]; | ||
if (typeof opts === 'function') { | ||
opts = {}; | ||
Array.prototype.splice.call(arguments, 2, 0, opts); | ||
} | ||
opts.cwd = wallaby.localProjectDir; | ||
return execFile.apply(this, arguments); | ||
}; | ||
require('./test/setup'); | ||
}, | ||
debug: true | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArtemGovorov how did you figure this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had been reading mocha source code and discovered it. Wallaby uses mocha a bit differently from how mocha CLI is using mocha :)