-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return the created test in xit
for bdd interface
#3143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test failure on AppVeyor is curious |
boneskull
added
the
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
label
Dec 11, 2017
we're seeing a seemingly random npm failure under Node.js v4, so I'm upgrading to npm v5.6.0. If this fails I'll create |
saucelabs flake? really? at least it's flake I haven't seen before. retrying |
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
… (mochajs#3143) * Fixes mochajs#3142 * added test cases suggested by @boneskull * fixed miswording * attempt to fix bizarre AppVeyor problem by way of npm upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
type: bug
a defect, confirmed by a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #3142
The bigger reason for this fix is to ensure consistency across across both active and pending tests (ie
it
andxit
).I've also added a test suite for
setting timeout by appending it to test
Alternate Designs
We can also remove the return statement to disable this feature in the bdd interface, but i personally favor having it around, maybe even document it after adding some more test cases!
Benefits
Since @boneskull does not encourage the use of the
this
keyword in writing tests, documenting this change might create a shift to increased usage of arrow functions and less usage ofthis
.Applicable issues
patch