Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return the created test in xit for bdd interface #3143

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Conversation

Bamieh
Copy link
Contributor

@Bamieh Bamieh commented Dec 11, 2017

Description of the Change

Fixes #3142

The bigger reason for this fix is to ensure consistency across across both active and pending tests (ie it and xit).

I've also added a test suite for setting timeout by appending it to test

Alternate Designs

We can also remove the return statement to disable this feature in the bdd interface, but i personally favor having it around, maybe even document it after adding some more test cases!

Benefits

Since @boneskull does not encourage the use of the this keyword in writing tests, documenting this change might create a shift to increased usage of arrow functions and less usage of this.

Applicable issues

patch

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.95% when pulling 36a2f1f on issue/3142 into 5fbbce9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.95% when pulling 7b82003 on issue/3142 into 5fbbce9 on master.

@boneskull
Copy link
Contributor

test failure on AppVeyor is curious

@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Dec 11, 2017
@boneskull
Copy link
Contributor

@Bamieh it's helpful to write "closes #xxxx" in the commit message somewhere as it will automatically close the associated issue upon merge, as well as link the commit to the issue (#3143)

@boneskull
Copy link
Contributor

we're seeing a seemingly random npm failure under Node.js v4, so I'm upgrading to npm v5.6.0. If this fails I'll create npm-debug.log as an artifact and try to get more info...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.95% when pulling e227a78 on issue/3142 into 5fbbce9 on master.

@boneskull
Copy link
Contributor

saucelabs flake? really? at least it's flake I haven't seen before. retrying

@boneskull boneskull merged commit 4c0df70 into master Dec 12, 2017
@boneskull boneskull deleted the issue/3142 branch December 12, 2017 06:54
@boneskull boneskull added this to the v4.1.0 milestone Dec 29, 2017
@boneskull boneskull added the type: bug a defect, confirmed by a maintainer label Dec 29, 2017
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
… (mochajs#3143)

* Fixes mochajs#3142

* added test cases suggested by @boneskull

* fixed miswording

* attempt to fix bizarre AppVeyor problem by way of npm upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout option to xits using arrow functions
3 participants