Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linting into an npm script. Relates to #2805 #2807

Merged
merged 1 commit into from
May 19, 2017
Merged

Conversation

Munter
Copy link
Contributor

@Munter Munter commented May 15, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 17a1770 on npm-script-lint into ** on master**.

@Munter Munter requested a review from ScottFreeCode May 15, 2017 12:36
Copy link
Contributor

@ScottFreeCode ScottFreeCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step closer to world Windows domination...

@dasilvacontin
Copy link
Contributor

@Munter why the to-merge label?

@Munter
Copy link
Contributor Author

Munter commented May 19, 2017

@dasilvacontin I was assuming it means this is ready to merge in. But it's probably easier for the next person finishing up a realease to do it, since they won't have to hunt down changes in reverse from the git log

@dasilvacontin
Copy link
Contributor

@Munter Hmm, I think it's simpler to merge directly. Simpler, less rules to follow, less assumptions to make.

I'd prefer to enforce all changes to go through PRs, so when doing the reverse scan on the git log I can safely focus only on the merge commits.

Also, if you wait to merge a bunch of PRs in one go, there could be conflicts. That would be horrible. 🤔

@Munter
Copy link
Contributor Author

Munter commented May 19, 2017

Yeah, didn't think that all the way through

@Munter Munter merged commit e249434 into master May 19, 2017
@Munter Munter deleted the npm-script-lint branch May 19, 2017 11:01
@dasilvacontin
Copy link
Contributor

All good. 😊

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Move linting into an npm script. Relates to mochajs#2805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants