-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move linting into an npm script. Relates to #2805 #2807
Conversation
Changes Unknown when pulling 17a1770 on npm-script-lint into ** on master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One step closer to world Windows domination...
@Munter why the |
@dasilvacontin I was assuming it means this is ready to merge in. But it's probably easier for the next person finishing up a realease to do it, since they won't have to hunt down changes in reverse from the git log |
@Munter Hmm, I think it's simpler to merge directly. Simpler, less rules to follow, less assumptions to make. I'd prefer to enforce all changes to go through PRs, so when doing the reverse scan on the git log I can safely focus only on the merge commits. Also, if you wait to merge a bunch of PRs in one go, there could be conflicts. That would be horrible. 🤔 |
Yeah, didn't think that all the way through |
All good. 😊 |
Move linting into an npm script. Relates to mochajs#2805
No description provided.