Skip to content

Commit 785aeb1

Browse files
authored
chore(test): drop AMD/'requirejs' (#4857)
1 parent ed640c4 commit 785aeb1

File tree

7 files changed

+1
-100
lines changed

7 files changed

+1
-100
lines changed

karma.conf.js

-25
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,6 @@ const addSauceLabsTestName = (testName, cfg) =>
269269
* - `tdd` - `tdd`-specific tests
270270
* - `qunit` - `qunit`-specific tests
271271
* - `esm` - ESM-specific tests
272-
* - `requirejs` - RequireJS-specific tests
273272
*
274273
* Since we can't change Mocha's interface on-the-fly, tests for specific interfaces
275274
* must be run in isolation.
@@ -297,10 +296,6 @@ const chooseTestSuite = (cfg, value) => {
297296
case 'esm':
298297
return addStandardDependencies({
299298
...addSauceLabsTestName('ESM Integration Tests', cfg),
300-
// just run against ChromeHeadless, since other browsers may not
301-
// support ESM.
302-
// XXX: remove following line when dropping IE11
303-
browsers: ['ChromeHeadless'],
304299
files: [
305300
{
306301
pattern: 'test/browser-specific/fixtures/esm.fixture.mjs',
@@ -312,26 +307,6 @@ const chooseTestSuite = (cfg, value) => {
312307
}
313308
]
314309
});
315-
case 'requirejs':
316-
// no standard deps because I'm too lazy to figure out how to make
317-
// them work with RequireJS. not important anyway
318-
return {
319-
...addSauceLabsTestName('RequireJS Tests', cfg),
320-
plugins: [...cfg.plugins, 'karma-requirejs'],
321-
frameworks: ['requirejs', ...cfg.frameworks],
322-
files: [
323-
{
324-
pattern: 'test/browser-specific/fixtures/requirejs/*.fixture.js',
325-
included: false
326-
},
327-
'test/browser-specific/requirejs-setup.js'
328-
],
329-
// this skips bundling the above tests & fixtures
330-
rollup: {
331-
...cfg.rollup,
332-
include: []
333-
}
334-
};
335310
default:
336311
return addStandardDependencies({
337312
...addSauceLabsTestName('Unit Tests', cfg)

package-lock.json

-38
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-scripts.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ module.exports = {
206206
browser: {
207207
default: {
208208
script:
209-
'nps clean build test.browser.unit test.browser.bdd test.browser.tdd test.browser.qunit test.browser.esm test.browser.requirejs test.browser.webpack',
209+
'nps clean build test.browser.unit test.browser.bdd test.browser.tdd test.browser.qunit test.browser.esm test.browser.webpack',
210210
description: 'Run browser tests'
211211
},
212212
unit: {
@@ -234,11 +234,6 @@ module.exports = {
234234
description: 'Run browser ES modules support test',
235235
hiddenFromHelp: true
236236
},
237-
requirejs: {
238-
script: 'cross-env MOCHA_TEST=requirejs nps test.browser.unit',
239-
description: 'Run RequireJS compat test',
240-
hiddenFromHelp: true
241-
},
242237
webpack: {
243238
script:
244239
'webpack --mode development --config ./test/browser-specific/fixtures/webpack/webpack.config.js',

package.json

-2
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@
114114
"karma-chrome-launcher": "^3.1.0",
115115
"karma-mocha": "^2.0.1",
116116
"karma-mocha-reporter": "^2.2.5",
117-
"karma-requirejs": "^1.1.0",
118117
"karma-sauce-launcher": "^4.3.6",
119118
"lint-staged": "^10.2.11",
120119
"markdown-it": "^12.3.2",
@@ -132,7 +131,6 @@
132131
"remark": "^14.0.2",
133132
"remark-github": "^11.2.2",
134133
"remark-inline-links": "^6.0.1",
135-
"requirejs": "^2.3.6",
136134
"rewiremock": "^3.14.3",
137135
"rimraf": "^3.0.2",
138136
"rollup": "^2.70.1",

test/browser-specific/fixtures/requirejs/lib.fixture.js

-3
This file was deleted.

test/browser-specific/fixtures/requirejs/main.fixture.js

-9
This file was deleted.

test/browser-specific/requirejs-setup.js

-17
This file was deleted.

0 commit comments

Comments
 (0)