Add go fix to CI, rm old build tags#148
Merged
Merged
Conversation
To not repeat shell's for loop for multiple targets, add "foreach" target and use it. It can also be used from the command line: $ make foreach Usage: make foreach CMD="commands to run for every package" make: *** [Makefile:17: foreach] Error 1 $ make foreach CMD="gofmt -w ." set -eu; \ for p in mountinfo mount sequential signal symlink user userns ; do \ (cd $p; gofmt -w .;) \ done Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Add running "go fix" to CI. Also, remove tidy target from the Makefile (developers hardly use it), replacing it with make foreach CMD="go mod tidy" Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
Author
|
@thaJeztah PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes old (Go < 1.17) build tags, and makes sure CI runs
go fix(which, unfortunately, is not part of any linter).