swarm-rafttool: add json output format flag #2898
Open
+147
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --format output flag which defaults to "text" (current style) and also accepts "json". Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
trapier
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2898 +/- ##
==========================================
- Coverage 61.7% 61.32% -0.39%
==========================================
Files 139 139
Lines 22615 22677 +62
==========================================
- Hits 13955 13906 -49
- Misses 7188 7304 +116
+ Partials 1472 1467 -5 |
trapier
commented
Sep 23, 2019
Author
trapier
left a comment
trapier
left a comment
There was a problem hiding this comment.
need to pretty-print json output.
Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
Author
|
now with pretty-printed json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add --format output flag to
dump-{object,snapshot,wal}which defaults to"text" (current style) and also accepts "json".
Hopefully this will greatly facilitate future analysis of raft dumps, which are
currently only available as walls of pretty printed protobuf.
- How I did it
Added cobra flag with validation and introduced switch statements to dump path.
- How to test it
dump-{object,snapshot,wal}with--format nope. Confirm this errorsand prints help.
dump-{object,snapshot,wal}without the --format flag, or with--format text. Confirm the output is unchanged from present.dump-{object,snapshot,wal}with--format json. Pipe the output tojqor other json parser and confirm there are no parsing errors. Confirminformation previously presented (e.g. event index from WAL) is still communicated
via the json format.
- Description for the changelog
N/A