Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/swarmkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 74cc943971952b960b52cd7498020feed4c41a1e
Choose a base ref
...
head repository: moby/swarmkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2501f6ef0f90edcaee4643247305e7ed2014eb79
Choose a head ref
  • 1 commit
  • 50 files changed
  • 1 contributor

Commits on Oct 12, 2024

  1. csi: remove unused startMockServer and github.com/rexray/gocsi depend… 

    …ency

This utility was used in manager/volumes/volumes_test.go, which got deleted
in b0a1aa6, making the startMockServer unused.

Remove the file, so that we can remove the problematic github.com/rexray/gocsi
dependency, which is unmaintained, and required us to use Drew's fork to
prevent legacy dependencies from being pulled in through the indirect
github.com/coreos/etcd/clientv3 dependency;

    go: finding module for package github.com/coreos/etcd/clientv3/concurrency
    go: finding module for package github.com/coreos/etcd/clientv3
    go: found github.com/coreos/etcd/clientv3 in github.com/coreos/etcd v3.3.27+incompatible
    go: found github.com/coreos/etcd/clientv3/concurrency in github.com/coreos/etcd v3.3.27+incompatible
    go: finding module for package github.com/coreos/go-systemd/journal
    go: finding module for package github.com/coreos/pkg/capnslog
    go: found github.com/coreos/pkg/capnslog in github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb
    go: found github.com/coreos/go-systemd/journal in github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf

The above resolution resulted in these legacy versions to be added;

    github.com/coreos/etcd v3.3.27+incompatible // indirect
    github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf // indirect
    github.com/coreos/pkg v0.0.0-20240122114842-bbd7aa9bf6fb // indirect

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    2501f6e View commit details
    Browse the repository at this point in the history
Loading