Add dummy proxy on port map #195
Conversation
|
moby/moby#13024 for reference |
|
@LK4D4 wouldn't this be solved if we start binding to ports when we allocate ports in port allocator? Once issue is the daemon host port is also allocated through the same api but in that we shouldn't bind the port because the daemon will start listening on it. But we can always provide another api like Right now the portallocator design is in such a way that it is not in sync with the OS. Which is a problem ... |
|
@mrjana It would, but now binding logic is in |
|
@LK4D4 Ideally we don't need a proxy. Just a few more state in portallocator which holds the bind reference. But since this is urgent for 1.7 I am fine with the current design |
|
@mrjana Yeah, ideally :) But userland-proxy is still defaut :/ |
It is needed in cases when mapped port is already bound, or another application bind mapped port. All this will be undetected because we use iptables and not net.Listen. Signed-off-by: Alexander Morozov <lk4d4@docker.com>
|
@mrjana I decided to remove mutex at all, because there is no references to proxy until |
|
@LK4D4 LGTM |
|
Thanks guys. LGTM. |
It is needed in cases when mapped port is already bound, or another
application bind mapped port. All this will be undetected because we use
iptables and not net.Listen.