Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with finally on react-native #78

Closed
chrisdrackett opened this issue Aug 9, 2019 · 1 comment · Fixed by #79
Closed

issues with finally on react-native #78

chrisdrackett opened this issue Aug 9, 2019 · 1 comment · Fixed by #79

Comments

@chrisdrackett
Copy link
Collaborator

I'm attempting to use mst-gql on react native and I've run into the following:

TypeError: new Promise(function (resolve, reject) {
      this$1.onResolve = resolve;
      this$1.onReject = reject;
    }).finally is not a function. (In 'new Promise(function (resolve, reject) {
      this$1.onResolve = resolve;
      this$1.onReject = reject;
    }).finally(function () {
      this$1.store.ssr && this$1.store.unpushPromise(this$1.promise);
    })', 'new Promise(function (resolve, reject) {
      this$1.onResolve = resolve;
      this$1.onReject = reject;
    }).finally' is undefined)

I think this might be related to: facebook/react-native#17972

I'm going to spend a little time on it today, but figured it was worth opening the issue

@chrisdrackett
Copy link
Collaborator Author

I can confirm that removing the finally fixes the issue on react-native. I'm pretty behind on promises in general, so I'll open a PR with a fix that might not be ideal :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant