Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace subscriptions-transport-ws with graphql-ws #330

Open
theonetheycallneo opened this issue May 26, 2021 · 7 comments
Open

Replace subscriptions-transport-ws with graphql-ws #330

theonetheycallneo opened this issue May 26, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@theonetheycallneo
Copy link

The subscriptions-transport-ws library is not being actively maintained. It is recommended that you use the graphql-ws library instead. For details read the GraphQL over WebSockets announcement.

Reference:
https://github.com/apollographql/subscriptions-transport-ws#graphql-ws

New GraphQL WebSocket library:
https://github.com/enisdenjo/graphql-ws

@beepsoft
Copy link
Collaborator

This would be a breaking change, but I think it is a good idea. What do you think, @jesse-savary?

@jesse-savary
Copy link
Member

I think this is a good idea; I'd like to review existing dependencies and replace things as needed.

@krstns
Copy link

krstns commented May 4, 2022

would it be possible to allow use of other libs instead? there's a big push to leave websockets in favour of other means of communication (mercure for example).

@beepsoft
Copy link
Collaborator

beepsoft commented May 4, 2022

I haven't seen this happening. Where is this push coming from? Who is using mercure in the context of graphql subscriptions? For now I see graphql-ws as a safe option.

@krstns
Copy link

krstns commented May 4, 2022

api-platform for one. I'm not saying that as part of mst-gql you would integrate mercure, just to create an option to use other libs.

@beepsoft
Copy link
Collaborator

beepsoft commented May 4, 2022

Oh, you mean to make the "backend" for subscriptions selectable? We vould then keep subscriptions-transport-ws for backward compatibility and add new backends like graphql-ws and mercure.

@krstns
Copy link

krstns commented May 10, 2022

yes, i don't expect this to be in the scope of the 'mst-gql' project but it would allow us to add custom implementations and then just call back to the root with the update to follow the same set of processes.

@jesse-savary jesse-savary added the enhancement New feature or request label Nov 6, 2022
@jesse-savary jesse-savary self-assigned this Nov 6, 2022
@jesse-savary jesse-savary added this to the v0.18.0 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants