Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in archived mobx-react repo results in a 404 #2646

Closed
Dakkers opened this issue Nov 25, 2020 · 6 comments
Closed

Link in archived mobx-react repo results in a 404 #2646

Dakkers opened this issue Nov 25, 2020 · 6 comments

Comments

@Dakkers
Copy link

Dakkers commented Nov 25, 2020

Intended outcome:
Go to the correct repo

Actual outcome:
404 and sadness

How to reproduce the issue:

  1. go to https://github.com/mobxjs/mobx-react
  2. click mobx

image

  1. get 404'd bro

image

Versions
N/A

@danielkcz
Copy link
Contributor

Thanks for reporting, I'll fix in the near future :)

@meepeek
Copy link

meepeek commented Dec 1, 2020

@FredyC I saw the archived repo and confuse of what to do with react integration. The guide in this repo seems to be missing. Could you explain a bit ? I used mobx-react in my project 2 years ago. What should I do for update ? Should I import observer from mobx now ? The guide in this repo and web still use mobx-react and mobx-react-lite

@mweststrate
Copy link
Member

@meepeek as the message suggests, the github repo's has been moved. That doesn't affect your project, as the npm package is still at the same place, unless you're directly building against github source urls.

@meepeek
Copy link

meepeek commented Dec 1, 2020

@mweststrate For the new project, I should still use npm install mobx-react and mobx-react-lite even though it has been archived. Is that correct ? What I am worry is about the code in archived repo might no longer get update in the future. If it was moved into mobx main repo then, should I just npm install mobx and import everything from mobx package ?

@mweststrate
Copy link
Member

@meepeek this is github, not npm. The source code is living at at different place now, that is all. Still maintained by the same team, so really nothing to worry about here, and it doesn't have any impact on your projects. Its just the internal move of an office within the same company

@danielkcz
Copy link
Contributor

Fixed links (it was wrong in lite repo as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants