-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Moving to monorepo #2530
Comments
Does this include closed issues? I was looking for a past discussion in mobx-react-lite and i am not able to read or find it. edit: specifically it was https://github.com/mobxjs/mobx-react/issues/744 and is now only available through google cache AFAICT |
Yea. I suppose it will block access to closed issues as well. Not the best, but what can you do :) I've transferred that issue and converted to discussion for you: #2531 |
If anyone is feeling on working on the documentation migration, help is certainly wanted. I will be able to get to this in a week or more. |
I would like to see the 3 versions align if possible. It would make keeping compatible versions a non issue. |
Nah, that doesn't make much sense. These packages are not that tightly coupled. The |
related proposal: move to yarn2 |
@Bnaya Can you elaborate on what would be the benefit of that? I tried to toy with Yarn2 shortly after its release and was a bit confused about it. |
Freddy i know they arent coupled , but what is the downside? The latest versions should always maintain cross compatibility and mobx now supports proxy/no proxy runtimes in the same version, so i only see benefits, but maybe Im missing something? |
I already said downside. Making a change to the binding package is not a good reason to publish the other two as well. Especially if the change is compatible and works with previous versions. This pattern makes sense for example to UI libraries where dependencies are harder to track and follow due to many packages. Similarly Babel with numerous plugins it's easier to track compatibility that way. |
While yarn 1 workspaces could work just fine, And since it's release yarn 2 have gained several stability milestones: I've opened a PR for that: |
And it's done. It was a rather tough chore, but everything seems to be working now. If I broke something I wasn't aware of, let me know :) Hopefully, everything will be easier to maintain now when it's in a single spot. Documentation for mobx-react(-lite) is still in their respective READMEs, but given the simplicity of the API layer, it can wait till someone is in the mood to integrate that with main docs. |
We want to move together mobx-react & mobx-react-lite (more later maybe) into this repo to ease on issue duplication and to provide better idea of where to find help.
The text was updated successfully, but these errors were encountered: