Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fails in angular 8 with 5.15 version #2193

Closed
anandshanbhag opened this issue Nov 8, 2019 · 4 comments
Closed

Unit test fails in angular 8 with 5.15 version #2193

anandshanbhag opened this issue Nov 8, 2019 · 4 comments

Comments

@anandshanbhag
Copy link

anandshanbhag commented Nov 8, 2019

The unit test seems to be failing while running in the headless chrome mode in Angular

version details are below;
mobx : 5.15.0
angular: 8.1.0
ERROR in ../node_modules/mobx/lib/api/flow.d.ts:8:83 - error TS2315: Type 'Generator' is not generic. 8 export declare function flow<R, Args extends any[]>(generator: (...args: Args) => Generator<any, R, any> | AsyncGenerator<any, R, any>): (...args: Args) => CancellablePromise<R>;~~~~~~~~~~~~~~~~~~~~~~ ../node_modules/mobx/lib/api/flow.d.ts:8:108 - error TS2304: Cannot find name 'AsyncGenerator'. 8 export declare function flow<R, Args extends any[]>(generator: (...args: Args) => Generator<any, R, any> | AsyncGenerator<any, R, any>): (...args: Args) => CancellablePromise<R>;

Note: Everything works perfectly with version 5.14.2

@tiagoaguiar100
Copy link

tiagoaguiar100 commented Nov 8, 2019

Hi @anandshanbhag , the problem is that the latest version of mobx requires typescript > 3.6.0. But doing that conflicts with the latest of @angular/compiler-cli requires typescript >=3.4.0 and <3.6.0.

In the end, I think it's better to stick with mobx 5.14.2

@johnhamm
Copy link

This effectively makes mobx versions higher than 5.14.2 incompatible with Angular.

@danielkcz
Copy link
Contributor

@johnhamm Did someone open an issue with Angular then? Obviously this is something that should be solved on their side.

@lock
Copy link

lock bot commented Jan 13, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants