Add dataclasses for ChargingProfile #648
Open
+54
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for remove_nones to work with the charging profile data structures it needs to be able to remove nones of nested dictionaries, as well as dictionaries made of lists of dictionaries (for example, a list of charging schedules represented as dicts). This commit modifies the logic, and adds tests
For now, dicts are acceptable to maintain backwards compatibility. Perhaps in v1.0 only the dataclass will be accepted.
* Change Decimal to float * Move dataclasses to separate charging_profile module * Add ChargingProfile type to RemoteStartTransaction payload
…drian/add_charging_profile_types Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
jerome-benoit
requested review from
OrangeTux and
Jared-Newell-Mobility
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #172 updated with master.
Smart charging algos conception and validation has become a requirement for charging infrastructure. Every single code lines that can help at implementing and testing it worse the effort.